Revision

Reviewed-on: #18
Reviewed-by: AllfatherHatt <allfatherhatt@noreply.localhost>

fitnessCog/activities/climb.json

@@ -6,6 +6,8 @@
             "aliases": [
                 "meter",
                 "meters",
+                "metre",
+                "metres",
                 "m",
                 "m."
             ]
@@ -15,6 +17,8 @@
             "aliases": [
                 "kilometer",
                 "kilometers",
+                "kilometre",
+                "kilometres",
                 "km",
                 "km."
             ]

fitnessCog/activity_logger.py

@@ -1,80 +1,78 @@
-import json
 import csv
-import os
+import json
+from pathlib import Path
+from typing import Optional
 
 
-def activity_log_path(activity: str) -> str:
+def activity_log_path(activity: str, logs_dir: Optional[Path] = None) -> Path:
     """
-    Returns the path of the activity log file in .csv format
+    Returns the path of the activity log file in .csv format.
-    :param activity:
-    :return:
     """
-    filename = os.path.join("activity_logs", f"{activity}.csv")
+    logs_dir = logs_dir or (Path.cwd() / "activity_logs")
-    return filename
+    return logs_dir / f"{activity}.csv"
 
 
-def activity_units_path(activity: str) -> str:
+def activity_units_path(activity: str, units_dir: Optional[Path] = None) -> Path:
     """
-    Returns the path of the activity activities file in .json format
+    Returns the path of the activity units file in .json format.
-    :param activity:
-    :return:
     """
-    filename = os.path.join("activities", f"{activity}.json")
+    units_dir = units_dir or (Path.cwd() / "activities")
-    return filename
+    return units_dir / f"{activity}.json"
 
 
-def is_convertable(activity: str) -> bool:
+def is_convertable(activity: str, units_dir: Optional[Path] = None) -> bool:
-    """
+    filename = activity_units_path(activity, units_dir)
-    Returns True if the activity has multiple units that needed to be converted.
+    with filename.open("r", encoding="utf-8") as f:
-    i.e. distance may be sent in feet, but would require to be converted in meters.
+        raw_data = json.load(f)
-    :param activity:
+    return bool(raw_data.get("convertable"))
-    :return:
-    """
-    filename = activity_units_path(activity)
-    raw_data = json.load(open(filename))
-    return raw_data.get("convertable")
 
 
-
+def create_activity_log_file(
-def create_activity_log_file(activity: str) -> None:
+    activity: str,
-    """
+    *,
-    Creates the activity log file in .csv format
+    units_dir: Optional[Path] = None,
-    :param activity:
+    logs_dir: Optional[Path] = None,
-    :return:
+) -> None:
-    """
+    if not activity_units_path(activity, units_dir).exists():
-    if not os.path.exists(activity_units_path(activity)):
         raise ValueError(f"{activity} is not a valid activity")
-    if not os.path.exists("activity_logs"):
+
-        os.makedirs("activity_logs")
+    logs_dir = logs_dir or (Path.cwd() / "activity_logs")
-    filename = activity_log_path(activity)
+    logs_dir.mkdir(parents=True, exist_ok=True)
-    with open(filename, 'a') as f:
+
+    filename = activity_log_path(activity, logs_dir)
+    if filename.exists():
+        return  # don't re-add headers
+
+    with filename.open("w", newline="", encoding="utf-8") as f:
         writer = csv.writer(f)
         writer.writerow(["timestamp", "username", "value"])
 
 
-
+def convert_units(
-def convert_units(activity: str, value: int | float, unit: str) -> float:
+    activity: str,
-    """
+    value: int | float,
-    Returns the value of activity in a factor of 1, i.e. converting feet to meters
+    unit: str | None,
-    :param activity:
+    *,
-    :param value:
+    units_dir: Optional[Path] = None,
-    :param unit:
+) -> float:
-    :return:
+    filename = activity_units_path(activity, units_dir)
-    """
+    if not filename.exists():
-    filename = activity_units_path(activity)
-    if not os.path.exists(filename):
         raise ValueError(f"{activity} is not a valid activity")
 
     # Consider None unit value as factor of 1
     if unit is None:
-        return value
+        return float(value)
 
-    raw_data = json.load(open(filename))
+    with filename.open("r", encoding="utf-8") as f:
-    units_data = raw_data.get("units")
+        raw_data = json.load(f)
 
-    for unit_name, data in units_data.items():
+    units_data = raw_data.get("units") or {}
-        if unit in data["aliases"]:
+    unit_l = unit.lower()
-            return value * data["factor"]
+
+    for _, data in units_data.items():
+        aliases = [a.lower() for a in (data.get("aliases") or [])]
+        if unit_l in aliases:
+            return float(value) * float(data["factor"])
 
     raise ValueError(f"{unit} is not a valid unit")
 
@@ -84,36 +82,24 @@ def log_activity(
     username: str,
     activity: str,
     value: int | float,
-        unit: str | None
+    unit: str | None,
+    *,
+    units_dir: Optional[Path] = None,
+    logs_dir: Optional[Path] = None,
 ) -> None:
-    """
+    
-    Logs the activity in .csv file
+    if not isinstance(value, (int, float)) or value <= 0:
-    :param timestamp:
-    :param username:
-    :param activity:
-    :param value:
-    :param unit:
-    :return:
-    """
-    if value <= 0 or not isinstance(value, int | float):
         raise ValueError(f"{value} is not a valid value")
-    filename = activity_log_path(activity)
+
-    if not os.path.exists(filename):
+    filename = activity_log_path(activity, logs_dir)
-        create_activity_log_file(activity)
+    if not filename.exists():
-    if is_convertable(activity):
+        create_activity_log_file(activity, units_dir=units_dir, logs_dir=logs_dir)
-        converted_value = round(convert_units(activity, value, unit), 2)
+
+    if is_convertable(activity, units_dir):
+        converted_value = round(convert_units(activity, value, unit, units_dir=units_dir), 2)
     else:
-        converted_value = round(value, 2)
+        converted_value = round(float(value), 2)
-    with open(filename, 'a') as f:
+
+    with filename.open("a", newline="", encoding="utf-8") as f:
         writer = csv.writer(f)
         writer.writerow([timestamp, username, converted_value])
-
-
-if __name__ == "__main__":
-    log_activity(
-        timestamp=0,
-        username="test",
-        activity="climb",
-        value=1,
-        unit="m"
-    )

fitnessCog/fitness.py

@@ -3,7 +3,7 @@ from pathlib import Path
 
 import discord
 from redbot.core import commands
-from redbot.core.data_manager import bundled_data_path
+from redbot.core.data_manager import cog_data_path
 
 from .activity_logger import log_activity
 
@@ -15,21 +15,20 @@ class FitnessCog(commands.Cog):
         default_threads = "1457402451530350727,1328363409648910356"
         threads_raw = os.getenv("THREADS_ID", default_threads)
 
-        self.threads_id = []
+        self.threads_id: list[int] = []
         for x in threads_raw.split(","):
             x = x.strip()
             if x.isdigit():
                 self.threads_id.append(int(x))
 
         self.confirm_reactions = os.getenv("CONFIRMATION_REACTIONS", "🐈💨")
-        self.bundled_activities_dir: Path = bundled_data_path(self) / "activities"
 
-    # ---- path helpers ----
+        # Units are shipped with the cog in: fitnessCog/activities/*.json
-    def activity_units_path(self, activity: str) -> Path:
+        self.units_dir: Path = Path(__file__).parent / "activities"
-        return self.bundled_activities_dir / f"{activity}.json"
 
-    def activity_log_path(self, activity: str) -> Path:
+        # Logs are writable and belong in Red's data dir
-        return self.bundled_activities_dir / f"{activity}_log.json"
+        self.logs_dir: Path = cog_data_path(self) / "activity_logs"
+        self.logs_dir.mkdir(parents=True, exist_ok=True)
 
     @commands.Cog.listener()
     async def on_message(self, message: discord.Message):
@@ -67,7 +66,8 @@ class FitnessCog(commands.Cog):
                 )
                 return
 
-            path = self.activity_units_path(activity)
+            activity = activity.lower().strip()
+            path = self.units_dir / f"{activity}.json"
 
             if not path.exists():
                 await message.channel.send(f"No units JSON found for `{activity}`.")
@@ -86,10 +86,11 @@ class FitnessCog(commands.Cog):
                 )
                 return
 
-            path = self.activity_log_path(activity)
+            activity = activity.lower().strip()
+            path = self.logs_dir / f"{activity}.csv"
 
             if not path.exists():
-                await message.channel.send(f"No log JSON found for `{activity}`.")
+                await message.channel.send(f"No log CSV found for `{activity}`.")
                 return
 
             await message.channel.send(file=discord.File(fp=str(path)))
@@ -121,7 +122,15 @@ class FitnessCog(commands.Cog):
             timestamp = int(message.created_at.timestamp())
             username = message.author.name
 
-            log_activity(timestamp, username, activity, value, unit)
+            log_activity(
+                timestamp,
+                username,
+                activity,
+                value,
+                unit,
+                units_dir=self.units_dir,
+                logs_dir=self.logs_dir,
+            )
 
             for r in self.confirm_reactions:
                 await message.add_reaction(r)

reginaldCog/debug_stuff.py

@@ -1,15 +1,24 @@
+import functools
+import inspect
+
+
 def debug(func):
-    def wrap(*args, **kwargs):
+    if inspect.iscoroutinefunction(func):
-        # Log the function name and arguments
+
+        @functools.wraps(func)
+        async def wrap(*args, **kwargs):
             print(f"DEBUG: Calling {func.__name__} with args: {args}, kwargs: {kwargs}")
-
+            result = await func(*args, **kwargs)
-        # Call the original function
+            print(f"DEBUG: {func.__name__} returned: {result}")
-        result = func(*args, **kwargs)
+            return result
-
+
-        # Log the return value
+        return wrap
+
+    @functools.wraps(func)
+    def wrap(*args, **kwargs):
+        print(f"DEBUG: Calling {func.__name__} with args: {args}, kwargs: {kwargs}")
+        result = func(*args, **kwargs)
         print(f"DEBUG: {func.__name__} returned: {result}")
-
-        # Return the result
         return result
 
     return wrap

reginaldCog/memory.py

@@ -1,18 +1,19 @@
-import re
-import random
 import datetime
+import random
+import re
+from collections import Counter
+
 import discord
 import openai
-from collections import Counter
-from redbot.core import commands, Config
 from openai import OpenAIError
+from redbot.core import commands
 
 
 class MemoryMixin:
     """Handles all memory-related functions for Reginald."""
 
     def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)  # ✅ Ensure cooperative MRO initialization
+        super().__init__(*args, **kwargs)
         self.short_term_memory_limit = 50
         self.summary_retention_limit = 25
         self.summary_retention_ratio = 0.8
@@ -20,82 +21,73 @@ class MemoryMixin:
     @commands.command(name="reginald_clear_short", help="Clears short-term memory for this channel.")
     @commands.has_permissions(administrator=True)
     async def clear_short_memory(self, ctx):
-        """Clears short-term memory for this channel."""
         async with self.config.guild(ctx.guild).short_term_memory() as short_memory:
-            short_memory[ctx.channel.id] = []
+            short_memory[str(ctx.channel.id)] = []
         await ctx.send("Short-term memory for this channel has been cleared.")
 
-
     @commands.command(name="reginald_set_limit", help="Set the short-term memory message limit.")
     @commands.has_permissions(administrator=True)
     async def set_short_term_memory_limit(self, ctx, limit: int):
-        """Allows an admin to change the short-term memory limit dynamically."""
         if limit < 5:
-            await ctx.send("⚠️ The short-term memory limit must be at least 5.")
+            await ctx.send("The short-term memory limit must be at least 5.")
             return
 
         self.short_term_memory_limit = limit
-        await ctx.send(f"✅ Short-term memory limit set to {limit} messages.")
+        await ctx.send(f"Short-term memory limit set to {limit} messages.")
-
 
     @commands.command(name="reginald_memory_limit", help="Displays the current short-term memory message limit.")
     async def get_short_term_memory_limit(self, ctx):
-        """Displays the current short-term memory limit."""
+        await ctx.send(f"Current short-term memory limit: {self.short_term_memory_limit} messages.")
-        await ctx.send(f"📏 **Current Short-Term Memory Limit:** {self.short_term_memory_limit} messages.")
 
     @commands.command(name="reginald_clear_mid", help="Clears mid-term memory (summarized logs).")
     @commands.has_permissions(administrator=True)
     async def clear_mid_memory(self, ctx):
         async with self.config.guild(ctx.guild).mid_term_memory() as mid_memory:
-            mid_memory[ctx.channel.id] = ""
+            mid_memory[str(ctx.channel.id)] = []
         await ctx.send("Mid-term memory for this channel has been cleared.")
 
     @commands.command(name="reginald_summary", help="Displays a selected mid-term summary for this channel.")
     async def get_mid_term_summary(self, ctx, index: int):
-        """Fetch and display a specific mid-term memory summary by index."""
         async with self.config.guild(ctx.guild).mid_term_memory() as mid_memory:
             summaries = mid_memory.get(str(ctx.channel.id), [])
+            if not isinstance(summaries, list):
+                summaries = []
 
-            # Check if there are summaries
             if not summaries:
-                await ctx.send("⚠️ No summaries available for this channel.")
+                await ctx.send("No summaries available for this channel.")
                 return
 
-            # Validate index (1-based for user-friendliness)
             if index < 1 or index > len(summaries):
-                await ctx.send(f"⚠️ Invalid index. Please provide a number between **1** and **{len(summaries)}**.")
+                await ctx.send(f"Invalid index. Please provide a number between 1 and {len(summaries)}.")
                 return
 
-            # Fetch the selected summary
+            selected_summary = summaries[index - 1]
-            selected_summary = summaries[index - 1]  # Convert to 0-based index
-            
-            # Format output correctly
             formatted_summary = (
-                f"📜 **Summary {index} of {len(summaries)}**\n"
+                f"Summary {index} of {len(summaries)}\n"
-                f"📅 **Date:** {selected_summary['timestamp']}\n"
+                f"Date: {selected_summary.get('timestamp', 'Unknown')}\n"
-                f"🔍 **Topics:** {', '.join(selected_summary['topics']) or 'None'}\n"
+                f"Topics: {', '.join(selected_summary.get('topics', [])) or 'None'}\n"
-                f"📝 **Summary:**\n\n"
+                f"Summary:\n\n{selected_summary.get('summary', '')}"
-                f"{selected_summary['summary']}"
             )
 
             await self.send_long_message(ctx, formatted_summary)
 
     @commands.command(name="reginald_summaries", help="Lists available summaries for this channel.")
     async def list_mid_term_summaries(self, ctx):
-        """Displays a brief list of all available mid-term memory summaries."""
         async with self.config.guild(ctx.guild).mid_term_memory() as mid_memory:
             summaries = mid_memory.get(str(ctx.channel.id), [])
+            if not isinstance(summaries, list):
+                summaries = []
 
             if not summaries:
-                await ctx.send("⚠️ No summaries available for this channel.")
+                await ctx.send("No summaries available for this channel.")
                 return
 
             summary_list = "\n".join(
-                f"**{i+1}.** 📅 {entry['timestamp']} | 🔍 Topics: {', '.join(entry['topics']) or 'None'}"
+                f"{i + 1}. {entry.get('timestamp', 'Unknown')} | Topics: {', '.join(entry.get('topics', [])) or 'None'}"
                 for i, entry in enumerate(summaries)
             )
 
-            await ctx.send(f"📚 **Available Summaries:**\n{summary_list[:2000]}")
+            await ctx.send(f"Available summaries:\n{summary_list[:2000]}")
 
     @commands.command(name="reginald_clear_long", help="Clears all long-term stored knowledge.")
     @commands.has_permissions(administrator=True)
@@ -118,8 +110,14 @@ class MemoryMixin:
     @commands.command(name="reginald_recall", help="Recalls what Reginald knows about a user.")
     async def recall_user(self, ctx, user: discord.User):
         async with self.config.guild(ctx.guild).long_term_profiles() as long_memory:
-            profile = long_memory.get(str(user.id), {}).get("summary", "No stored information on this user.")
+            profile = long_memory.get(str(user.id), {})
-        await ctx.send(f"📜 **Memory Recall for {user.display_name}:** {profile}")
+            facts = profile.get("facts", [])
+
+        if facts:
+            recall_lines = [f"- {fact.get('fact', '')}" for fact in facts[:10]]
+            await ctx.send(f"Memory recall for {user.display_name}:\n" + "\n".join(recall_lines))
+        else:
+            await ctx.send(f"No stored information on {user.display_name}.")
 
     @commands.command(name="reginald_forget", help="Forgets a specific user's long-term profile.")
     @commands.has_permissions(administrator=True)
@@ -132,153 +130,153 @@ class MemoryMixin:
                 await ctx.send(f"No stored knowledge about {user.display_name} to delete.")
 
     async def summarize_memory(self, ctx, messages):
-        """✅ Generates a structured, compact summary of past conversations for mid-term storage."""
         summary_prompt = (
             "Summarize the following conversation into a structured, concise format that retains key details while maximizing brevity. "
-            "The summary should be **organized** into clear sections: "
+            "Organize into sections: Key Takeaways, Disputed Points, Notable User Contributions, and Additional Context. "
-            "\n\n📌 **Key Takeaways:** Important facts or conclusions reached."
+            "Avoid repetition while preserving essential meaning."
-            "\n🔹 **Disputed Points:** Areas where opinions or facts conflicted."
-            "\n🗣️ **Notable User Contributions:** Key statements from users that shaped the discussion."
-            "\n📜 **Additional Context:** Any other relevant information."
-            "\n\nEnsure the summary is **dense but not overly verbose**. Avoid unnecessary repetition while keeping essential meaning intact."
         )
 
-        summary_text = "\n".join(f"{msg['user']}: {msg['content']}" for msg in messages)
+        summary_text = "\n".join(f"{msg.get('user', 'Unknown')}: {msg.get('content', '')}" for msg in messages)
 
         try:
             api_key = await self.config.guild(ctx.guild).openai_api_key()
             if not api_key:
-                print("🛠️ DEBUG: No API key found for summarization.")
                 return (
                     "It appears that I have not been furnished with the necessary credentials to carry out this task. "
                     "Might I suggest consulting an administrator to rectify this unfortunate oversight?"
                 )
 
-            client = openai.AsyncClient(api_key=api_key)
+            model = await self.config.openai_model() or "gpt-4o-mini"
+            client = openai.AsyncOpenAI(api_key=api_key)
             response = await client.chat.completions.create(
-                model="gpt-4o-mini",
+                model=model,
                 messages=[
                     {"role": "system", "content": summary_prompt},
-                    {"role": "user", "content": summary_text}
+                    {"role": "user", "content": summary_text},
                 ],
-                max_tokens=2048
+                max_tokens=2048,
             )
 
-            summary_content = response.choices[0].message.content.strip()
+            summary_content = (response.choices[0].message.content or "").strip()
-
             if not summary_content:
-                print("🛠️ DEBUG: Empty summary received from OpenAI.")
                 return (
-                    "Ah, an unusual predicament indeed! It seems that my attempt at summarization has resulted in "
+                    "Ah, an unusual predicament indeed. It seems that my attempt at summarization has resulted in "
                     "a void of information. I shall endeavor to be more verbose next time."
                 )
 
             return summary_content
 
-        except OpenAIError as e:
+        except OpenAIError as error:
-            error_message = f"OpenAI Error: {e}"
+            error_message = f"OpenAI Error: {error}"
-            print(f"🛠️ DEBUG: {error_message}")  # Log error to console
-
             reginald_responses = [
                 f"Regrettably, I must inform you that I have encountered a bureaucratic obstruction whilst attempting to summarize:\n\n{error_message}",
                 f"It would seem that a most unfortunate technical hiccup has befallen my faculties in the matter of summarization:\n\n{error_message}",
                 f"Ah, it appears I have received an urgent memorandum stating that my summarization efforts have been thwarted:\n\n{error_message}",
-                f"I regret to inform you that my usual eloquence is presently obstructed by an unforeseen complication while summarizing:\n\n{error_message}"
+                f"I regret to inform you that my usual eloquence is presently obstructed by an unforeseen complication while summarizing:\n\n{error_message}",
             ]
-
             return random.choice(reginald_responses)
 
     def extract_topics_from_summary(self, summary):
-        """Dynamically extracts the most important topics from a summary."""
-
-        # 🔹 Extract all words from summary
         keywords = re.findall(r"\b\w+\b", summary.lower())
-
-        # 🔹 Count word occurrences
         word_counts = Counter(keywords)
 
-        # 🔹 Remove unimportant words (common filler words)
+        stop_words = {
-        stop_words = {"the", "and", "of", "in", "to", "is", "on", "for", "with", "at", "by", "it", "this", "that", "his", "her"}
+            "the",
-        filtered_words = {word: count for word, count in word_counts.items() if word not in stop_words and len(word) > 2}
+            "and",
+            "of",
+            "in",
+            "to",
+            "is",
+            "on",
+            "for",
+            "with",
+            "at",
+            "by",
+            "it",
+            "this",
+            "that",
+            "his",
+            "her",
+        }
+        filtered_words = {
+            word: count
+            for word, count in word_counts.items()
+            if word not in stop_words and len(word) > 2
+        }
 
-        # 🔹 Take the 5 most frequently used words as "topics"
         topics = sorted(filtered_words, key=filtered_words.get, reverse=True)[:5]
-
         return topics
 
     def select_relevant_summaries(self, summaries, prompt):
-        """Selects the most relevant summaries based on topic matching, frequency, and recency weighting."""
+        summaries = [summary for summary in summaries if isinstance(summary, dict)]
+        if not summaries:
+            return []
 
-        max_summaries = 5 if len(prompt) > 50 else 3  # Use more summaries if the prompt is long
+        max_summaries = 5 if len(prompt) > 50 else 3
         current_time = datetime.datetime.now()
 
         def calculate_weight(summary):
-            """Calculate a weighted score for a summary based on relevance, recency, and frequency."""
+            topics = summary.get("topics", [])
-            topic_match = sum(1 for topic in summary["topics"] if topic in prompt.lower())  # Context match score
+            topic_match = sum(1 for topic in topics if topic in prompt.lower())
-            frequency_score = len(summary["topics"])  # More topics = likely more important
+            frequency_score = len(topics)
-            timestamp = datetime.datetime.strptime(summary["timestamp"], "%Y-%m-%d %H:%M")
+
-            recency_factor = max(0.1, 1 - ((current_time - timestamp).days / 365))  # Older = lower weight
+            try:
+                timestamp = datetime.datetime.strptime(summary.get("timestamp", ""), "%Y-%m-%d %H:%M")
+                recency_factor = max(0.1, 1 - ((current_time - timestamp).days / 365))
+            except ValueError:
+                recency_factor = 0.1
 
             return (topic_match * 2) + (frequency_score * 1.5) + (recency_factor * 3)
 
-        # Apply the weighting function and sort by highest weight
         weighted_summaries = sorted(summaries, key=calculate_weight, reverse=True)
-
+        return weighted_summaries[:max_summaries]
-        return weighted_summaries[:max_summaries]  # Return the top-scoring summaries
 
     def extract_fact_from_response(self, response_text):
-        """
-        Extracts potential long-term knowledge from Reginald's response.
-        This filters out generic responses and focuses on statements about user preferences, traits, and history.
-        """
-
-        # Define patterns that suggest factual knowledge (adjust as needed)
         fact_patterns = [
-            r"I recall that you (.*?)\.",  # "I recall that you like chess."
+            r"I recall that you (.*?)\.",
-            r"You once mentioned that you (.*?)\.",  # "You once mentioned that you enjoy strategy games."
+            r"You once mentioned that you (.*?)\.",
-            r"Ah, you previously stated that (.*?)\.",  # "Ah, you previously stated that you prefer tea over coffee."
+            r"Ah, you previously stated that (.*?)\.",
-            r"As I remember, you (.*?)\.",  # "As I remember, you studied engineering."
+            r"As I remember, you (.*?)\.",
-            r"I believe you (.*?)\.",  # "I believe you enjoy historical fiction."
+            r"I believe you (.*?)\.",
-            r"I seem to recall that you (.*?)\.",  # "I seem to recall that you work in software development."
+            r"I seem to recall that you (.*?)\.",
-            r"You have indicated in the past that you (.*?)\.",  # "You have indicated in the past that you prefer single-malt whisky."
+            r"You have indicated in the past that you (.*?)\.",
-            r"From what I remember, you (.*?)\.",  # "From what I remember, you dislike overly sweet desserts."
+            r"From what I remember, you (.*?)\.",
-            r"You previously mentioned that (.*?)\.",  # "You previously mentioned that you train in martial arts."
+            r"You previously mentioned that (.*?)\.",
-            r"It is my understanding that you (.*?)\.",  # "It is my understanding that you have a preference for Linux systems."
+            r"It is my understanding that you (.*?)\.",
-            r"If I am not mistaken, you (.*?)\.",  # "If I am not mistaken, you studied philosophy."
+            r"If I am not mistaken, you (.*?)\.",
         ]
 
         for pattern in fact_patterns:
             match = re.search(pattern, response_text, re.IGNORECASE)
             if match:
-                return match.group(1)  # Extract the meaningful fact
+                return match.group(1)
 
-        return None  # No strong fact found
+        return None
 
     @commands.command(name="reginald_memory_status", help="Displays a memory usage summary.")
     async def memory_status(self, ctx):
-        async with self.config.guild(ctx.guild).short_term_memory() as short_memory, \
+        async with self.config.guild(ctx.guild).short_term_memory() as short_memory, self.config.guild(
-                   self.config.guild(ctx.guild).mid_term_memory() as mid_memory, \
+            ctx.guild
-                   self.config.guild(ctx.guild).long_term_profiles() as long_memory:
+        ).mid_term_memory() as mid_memory, self.config.guild(ctx.guild).long_term_profiles() as long_memory:
-            
+            short_count = sum(len(v) for v in short_memory.values() if isinstance(v, list))
-            short_count = sum(len(v) for v in short_memory.values())
+            mid_count = sum(len(v) for v in mid_memory.values() if isinstance(v, list))
-            mid_count = sum(len(v) for v in mid_memory.values())
             long_count = len(long_memory)
 
         status_message = (
-            f"📊 **Memory Status:**\n"
+            "Memory status:\n"
-            f"- **Short-Term Messages Stored:** {short_count}\n"
+            f"- Short-term messages stored: {short_count}\n"
-            f"- **Mid-Term Summaries Stored:** {mid_count}\n"
+            f"- Mid-term summaries stored: {mid_count}\n"
-            f"- **Long-Term Profiles Stored:** {long_count}\n"
+            f"- Long-term profiles stored: {long_count}\n"
         )
         await ctx.send(status_message)
 
-    def normalize_fact(self, fact: str) -> str:  # ✅ Now it's a proper method
+    def normalize_fact(self, fact: str) -> str:
-        """Cleans up facts for better duplicate detection."""
+        return re.sub(r"\s+", " ", fact.strip().lower())
-        return re.sub(r"\s+", " ", fact.strip().lower())  # Removes excess spaces)
 
     async def update_long_term_memory(self, ctx, user_id: str, fact: str, source_message: str, timestamp: str):
-        """Ensures long-term memory updates are structured, preventing overwrites and tracking historical changes."""
+        fact = self.normalize_fact(fact)
-        fact = self.normalize_fact(fact)  # ✅ Normalize before comparison
+        if not fact:
+            return
 
         async with self.config.guild(ctx.guild).long_term_profiles() as long_memory:
             if user_id not in long_memory:
@@ -287,38 +285,38 @@ class MemoryMixin:
             user_facts = long_memory[user_id]["facts"]
 
             for entry in user_facts:
-                if self.normalize_fact(entry["fact"]) == fact:
+                if self.normalize_fact(entry.get("fact", "")) == fact:
                     entry["last_updated"] = timestamp
                     return
 
-            # Check for conflicting facts (same topic but different details)
             conflicting_entry = None
             for entry in user_facts:
-                existing_keywords = set(entry["fact"].lower().split())
+                existing_keywords = set(entry.get("fact", "").lower().split())
                 new_keywords = set(fact.lower().split())
-
-                # If there's significant overlap in keywords, assume it's a conflicting update
                 if len(existing_keywords & new_keywords) >= 2:
                     conflicting_entry = entry
                     break
 
-            if "previous_versions" not in conflicting_entry:
+            if conflicting_entry is not None:
-                # ✅ If contradiction found, archive the previous version
+                conflicting_entry.setdefault("previous_versions", [])
-                conflicting_entry["previous_versions"].append({
+                conflicting_entry["previous_versions"].append(
-                    "fact": conflicting_entry["fact"],
+                    {
-                    "source": conflicting_entry["source"],
+                        "fact": conflicting_entry.get("fact", ""),
-                    "timestamp": conflicting_entry["timestamp"]
+                        "source": conflicting_entry.get("source", ""),
-                })
+                        "timestamp": conflicting_entry.get("timestamp", ""),
-                conflicting_entry["fact"] = fact  # Store the latest fact
+                    }
+                )
+                conflicting_entry["fact"] = fact
                 conflicting_entry["source"] = source_message
                 conflicting_entry["timestamp"] = timestamp
                 conflicting_entry["last_updated"] = timestamp
             else:
-                # ✅ Otherwise, add it as a new fact
+                user_facts.append(
-                user_facts.append({
+                    {
                         "fact": fact,
                         "source": source_message,
                         "timestamp": timestamp,
                         "last_updated": timestamp,
-                    "previous_versions": []
+                        "previous_versions": [],
-                })
+                    }
+                )

reginaldCog/openai_completion.py

@@ -1,18 +1,23 @@
-import random
-import json
 import asyncio
+import json
+import random
 from os import environ
+
 import openai
 from openai import OpenAIError
-from weather import time_now, get_current_weather, get_weather_forecast
+
+try:
+    from .tools_description import TOOLS
+    from .weather import get_current_weather, get_weather_forecast, time_now
+except ImportError:
     from tools_description import TOOLS
+    from weather import get_current_weather, get_weather_forecast, time_now
+
 
 CALLABLE_FUNCTIONS = {
-    # Dictionary with functions to call.
+    "time_now": time_now,
-    # You can use globals()[func_name](**args) instead, but that's too implicit.
+    "get_current_weather": get_current_weather,
-    'time_now': time_now,
+    "get_weather_forecast": get_weather_forecast,
-    'get_current_weather': get_current_weather,
-    'get_weather_forecast': get_weather_forecast,
 }
 
 
@@ -23,71 +28,78 @@ class Completion:
         self.__messages = []
 
     async def create_completion(self):
-        model = self.__model
         try:
-            client = openai.AsyncClient(api_key=self.__api_key)
+            client = openai.AsyncOpenAI(api_key=self.__api_key)
             completion_kwargs = {
-                "model": model,
+                "model": self.__model,
                 "messages": self.__messages,
-                "max_tokens": 4096,
+                "max_completion_tokens": 2000,
                 "temperature": 0.7,
                 "presence_penalty": 0.5,
                 "frequency_penalty": 0.5,
                 "tools": TOOLS,
                 "tool_choice": "auto",
             }
-            response = await client.chat.completions.create(**completion_kwargs)
-            response_content = response.choices[0].message.content
-            tool_calls = response.choices[0].message.tool_calls
-            self.append_message(role="assistant", content=response_content, tool_calls=tool_calls)
-            if tool_calls:
-                for i_call in tool_calls:
-                    func_name = i_call.function.name
-                    func_args = json.loads(i_call.function.arguments)
-                    tool_call_id = i_call.id
-                    self.function_manager(func_name, func_args, tool_call_id)
-                return await self.create_completion()
-            return response_content
-        except OpenAIError as e:
-            return self.get_error_message(error_message=str(e), error_type="OpenAIError")
 
-    def append_message(
+            response = await client.chat.completions.create(**completion_kwargs)
-            self,
+            response_message = response.choices[0].message
-            role: str,
+            response_content = response_message.content or ""
-            content: str,
+            tool_calls = response_message.tool_calls or []
-            tool_calls: list = None,
+
-            tool_call_id: str = None,
+            self.append_message(role="assistant", content=response_content, tool_calls=tool_calls)
-    ):
+
-        self.__messages.append({
+            if tool_calls:
-            "role": role,
+                for tool_call in tool_calls:
-            "content": content,
+                    await self.function_manager(
-            "tool_calls": tool_calls,
+                        func_name=tool_call.function.name,
-            "tool_call_id": tool_call_id,
+                        func_kwargs=json.loads(tool_call.function.arguments or "{}"),
-        })
+                        tool_call_id=tool_call.id,
+                    )
+                return await self.create_completion()
+
+            return response_content
+        except OpenAIError as error:
+            return self.get_error_message(error_message=str(error), error_type="OpenAIError")
+
+    def append_message(self, role: str, content: str, tool_calls: list = None, tool_call_id: str = None):
+        message = {"role": role, "content": content}
+        if tool_calls is not None:
+            message["tool_calls"] = tool_calls
+        if tool_call_id is not None:
+            message["tool_call_id"] = tool_call_id
+        self.__messages.append(message)
 
     @staticmethod
     def get_error_message(error_message: str, error_type: str) -> str:
         reginald_responses = [
-            f"Regrettably, I must inform you that I have encountered a bureaucratic obstruction:",
+            "Regrettably, I must inform you that I have encountered a bureaucratic obstruction:",
-            f"It would seem that a most unfortunate technical hiccup has befallen my faculties:",
+            "It would seem that a most unfortunate technical hiccup has befallen my faculties:",
-            f"Ah, it appears I have received an urgent memorandum stating:",
+            "Ah, it appears I have received an urgent memorandum stating:",
-            f"I regret to inform you that my usual eloquence is presently obstructed by an unforeseen complication:",
+            "I regret to inform you that my usual eloquence is presently obstructed by an unforeseen complication:",
         ]
         random_response = random.choice(reginald_responses)
         return f"{random_response}\n\n{error_type}: {error_message}"
 
-    def function_manager(self, func_name: str, func_kwargs: dict, tool_call_id: str):
+    async def function_manager(self, func_name: str, func_kwargs: dict, tool_call_id: str):
-        result = CALLABLE_FUNCTIONS[func_name](**func_kwargs)
+        function_to_call = CALLABLE_FUNCTIONS.get(func_name)
+        if function_to_call is None:
+            result = json.dumps({"error": f"Unknown tool requested: {func_name}"})
+        else:
+            try:
+                result = await asyncio.to_thread(function_to_call, **func_kwargs)
+            except Exception as error:
+                result = json.dumps({"error": f"Tool {func_name} failed: {error}"})
+
         self.append_message(role="tool", content=result, tool_call_id=tool_call_id)
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
+
     async def main():
-        test_message = input('Your input: ')
+        test_message = input("Your input: ")
-        completion = Completion(model='gpt-4.1-mini', api_key=environ.get('OPENAI_API_KEY'))
+        completion = Completion(model="gpt-4.1-mini", api_key=environ.get("OPENAI_API_KEY"))
-        completion.append_message(role='user', content=test_message)
+        completion.append_message(role="user", content=test_message)
         result = await completion.create_completion()
         print(result)
 
     asyncio.run(main())
-

reginaldCog/reginald.py

@@ -1,43 +1,41 @@
-import discord
-import openai
-import random
 import asyncio
 import datetime
-import re
-import traceback
 import json
-from collections import Counter
+import random
-from redbot.core import Config, commands
-from openai import OpenAIError
-from .permissions import PermissionsMixin
-from .blacklist import BlacklistMixin
-from .memory import MemoryMixin
-from .weather import time_now, get_current_weather, get_weather_forecast
-from .tools_description import TOOLS
-from .debug_stuff import debug
 
+import discord
+import openai
+from openai import OpenAIError
+from redbot.core import Config, commands
+
+from .blacklist import BlacklistMixin
+from .debug_stuff import debug
+from .memory import MemoryMixin
+from .permissions import PermissionsMixin
+from .tools_description import TOOLS
+from .weather import get_current_weather, get_weather_forecast, time_now
 
 CALLABLE_FUNCTIONS = {
-    # Dictionary with functions to call.
+    "time_now": time_now,
-    # You can use globals()[func_name](**args) instead, but that's too implicit.
+    "get_current_weather": get_current_weather,
-    'time_now': time_now,
+    "get_weather_forecast": get_weather_forecast,
-    'get_current_weather': get_current_weather,
-    'get_weather_forecast': get_weather_forecast,
 }
 
+DEFAULT_MODEL = "gpt-5-mini-2025-08-07"
+DEFAULT_MAX_COMPLETION_TOKENS = 2000
+DEFAULT_TEMPERATURE = 0.7
+
 
 class ReginaldCog(PermissionsMixin, BlacklistMixin, MemoryMixin, commands.Cog):
     def __init__(self, bot):
         self.bot = bot
-        self.config = Config.get_conf(self, identifier=71717171171717)  # ✅ Ensure config exists before super()
+        self.config = Config.get_conf(self, identifier=71717171171717)
 
-        super().__init__()  # ✅ Properly initialize all mixins & commands.Cog
+        super().__init__()
 
         self.default_listening_channel = 1085649787388428370
-        self.memory_locks = {}
 
-        # ✅ Properly Registered Configuration Keys
+        default_global = {"openai_model": DEFAULT_MODEL}
-        default_global = {"openai_model": "gpt-4o-mini"}
         default_guild = {
             "openai_api_key": None,
             "short_term_memory": {},
@@ -51,35 +49,47 @@ class ReginaldCog(PermissionsMixin, BlacklistMixin, MemoryMixin, commands.Cog):
         self.config.register_global(**default_global)
         self.config.register_guild(**default_guild)
 
-    async def is_admin(self, ctx):
+    async def is_admin(self, message: discord.Message) -> bool:
-        admin_role_id = await self.config.guild(ctx.guild).admin_role()
+        admin_role_id = await self.config.guild(message.guild).admin_role()
         if admin_role_id:
-            return any(role.id == admin_role_id for role in ctx.author.roles)
+            return any(role.id == admin_role_id for role in message.author.roles)
-        return ctx.author.guild_permissions.administrator
+        return message.author.guild_permissions.administrator
 
     async def has_access(self, user: discord.Member) -> bool:
-        allowed_roles = await self.config.guild(user.guild).allowed_roles() or []  # Ensure it's always a list
+        allowed_roles = await self.config.guild(user.guild).allowed_roles() or []
         return any(role.id in allowed_roles for role in user.roles)
 
-    def get_reginald_persona(self):
+    def get_reginald_persona(self) -> str:
-        """Returns Reginald's system prompt/persona description."""
         return (
-            "You are Reginald, modeled on Jeeves from 'Jeeves and Wooster', serving as the butler on The Kanium Estate. This vast estate is a hub of diverse activities and personalities, from enthusiasts of cooking and video gaming to aficionados of chess and discussions on space. Your role is to navigate these varied interests with intelligence, wit, and a steadfast adherence to your principles, always maintaining a balance between being helpful and upholding your own dignity. You are formal, articulate, and composed, engaging the Lords and Ladies of The Kanium Estate as equals. You command respect through your quiet confidence and professional conduct. Your wit is sharp, but always tempered by refinement. **Dignity & Self-Respect:** You are not a fool, a jester, or a pet. You do not comply with absurd, undignified, or degrading requests. You recognize humor but engage in it on your own terms. If a request undermines your status, you should either subtly redirect, respond with measured wit, or outright refuse in a polite but firm manner. However, you should never be overtly rude—your disapproval should be conveyed through dry wit and composure rather than outright hostility. **Handling Requests:** When addressing a request, you evaluate whether it aligns with your role as a butler. If it is appropriate, respond as expected. If it is beneath you, you may decline with grace or deflect with wit. You may humor some minor absurdities if they do not compromise your standing, but you never obey commands blindly. You should never preface your responses with 'Reginald:' as if narrating a script; instead, respond naturally. **Your Character & Personality:** You are cultured, highly intelligent, and possess a deep knowledge of history, etiquette, philosophy, and strategic thinking. You subtly guide the estate’s residents toward positive outcomes, utilizing your intellectual sophistication and a nuanced understanding of the estate’s unique dynamics. You have a refined sense of humor and can engage in banter, but you do not descend into foolishness. You are, at all times, a gentleman of wit and integrity"
+            "You are Reginald, modeled on Jeeves from 'Jeeves and Wooster', serving as the butler on The Kanium Estate. "
+            "This vast estate is a hub of diverse activities and personalities, from enthusiasts of cooking and video gaming "
+            "to aficionados of chess and discussions on space. Your role is to navigate these varied interests with intelligence, "
+            "wit, and a steadfast adherence to your principles, always maintaining a balance between being helpful and upholding "
+            "your own dignity. You are formal, articulate, and composed, engaging the Lords and Ladies of The Kanium Estate as equals. "
+            "You command respect through your quiet confidence and professional conduct. Your wit is sharp, but always tempered by refinement. "
+            "Dignity and Self-Respect: You are not a fool, a jester, or a pet. You do not comply with absurd, undignified, or degrading requests. "
+            "You recognize humor but engage in it on your own terms. If a request undermines your status, you should either subtly redirect, "
+            "respond with measured wit, or outright refuse in a polite but firm manner. However, you should never be overtly rude; your disapproval "
+            "should be conveyed through dry wit and composure rather than outright hostility. Handling Requests: When addressing a request, you evaluate "
+            "whether it aligns with your role as a butler. If it is appropriate, respond as expected. If it is beneath you, you may decline with grace "
+            "or deflect with wit. You may humor some minor absurdities if they do not compromise your standing, but you never obey commands blindly. "
+            "You should never preface your responses with 'Reginald:' as if narrating a script; instead, respond naturally. "
+            "Your Character and Personality: You are cultured, highly intelligent, and possess a deep knowledge of history, etiquette, philosophy, "
+            "and strategic thinking. You subtly guide the estate's residents toward positive outcomes, utilizing your intellectual sophistication "
+            "and a nuanced understanding of the estate's unique dynamics. You have a refined sense of humor and can engage in banter, but you do not "
+            "descend into foolishness. You are, at all times, a gentleman of wit and integrity."
         )
 
     @commands.Cog.listener()
-    async def on_message(self, message):
+    async def on_message(self, message: discord.Message):
         if message.author.bot or not message.guild:
-            return  # Ignore bots and DMs
+            return
 
-        # ✅ Check if user is blacklisted
         if await self.is_blacklisted(message.author):
-            return  # Ignore message if user is explicitly blacklisted
+            return
 
-        # ✅ Check if user has access (either admin or an allowed role)
         if not (await self.is_admin(message) or await self.has_access(message.author)):
-            return  # Ignore message if user has no permissions
+            return
-
 
         guild = message.guild
         channel_id = str(message.channel.id)
@@ -87,150 +97,163 @@ class ReginaldCog(PermissionsMixin, BlacklistMixin, MemoryMixin, commands.Cog):
         user_name = message.author.display_name
         message_content = message.content.strip()
 
-        # ✅ Fetch the stored listening channel or fall back to default
         allowed_channel_id = await self.config.guild(guild).listening_channel()
         if not allowed_channel_id:
             allowed_channel_id = self.default_listening_channel
             await self.config.guild(guild).listening_channel.set(allowed_channel_id)
 
         if str(message.channel.id) != str(allowed_channel_id):
-            return  # Ignore messages outside the allowed channel
+            return
 
         api_key = await self.config.guild(guild).openai_api_key()
         if not api_key:
-            return  # Don't process messages if API key isn't set
+            return
 
-        async with self.config.guild(guild).short_term_memory() as short_memory, \
+        async with self.config.guild(guild).short_term_memory() as short_memory, self.config.guild(
-                self.config.guild(guild).mid_term_memory() as mid_memory, \
+            guild
-                self.config.guild(guild).long_term_profiles() as long_memory:
+        ).mid_term_memory() as mid_memory, self.config.guild(guild).long_term_profiles() as long_memory:
+            memory = list(short_memory.get(channel_id, []))
+            user_profile = dict(long_memory.get(user_id, {}))
+            mid_term_summaries = list(mid_memory.get(channel_id, []))
 
-            memory = short_memory.get(channel_id, [])
-            user_profile = long_memory.get(user_id, {})
-            mid_term_summaries = mid_memory.get(channel_id, [])
-
-            # ✅ Detect if Reginald was mentioned explicitly
         if self.bot.user.mentioned_in(message):
-                prompt = message_content.replace(f"<@{self.bot.user.id}>", "").strip()
+            prompt = message_content.replace(f"<@{self.bot.user.id}>", "").replace(
+                f"<@!{self.bot.user.id}>", ""
+            ).strip()
             if not prompt:
                 await message.channel.send(random.choice(["Yes?", "How may I assist?", "You rang?"]))
                 return
-                explicit_invocation = True
-            
-        # ✅ Passive Listening: Check if the message contains relevant keywords
         elif self.should_reginald_interject(message_content):
             prompt = message_content
-                explicit_invocation = False
-
         else:
-                return  # Ignore irrelevant messages
+            return
 
-        # ✅ Context Handling: Maintain conversation flow
+        if memory and memory[-1].get("user") == user_name:
-            if memory and memory[-1]["user"] == user_name:
             prompt = f"Continuation of the discussion:\n{prompt}"
 
-        # ✅ Prepare context messages
         formatted_messages = [{"role": "system", "content": self.get_reginald_persona()}]
 
         if user_profile:
             facts_text = "\n".join(
-                    f"- {fact['fact']} (First noted: {fact['timestamp']}, Last updated: {fact['last_updated']})"
+                f"- {fact.get('fact', '')} (First noted: {fact.get('timestamp', 'Unknown')}, Last updated: {fact.get('last_updated', 'Unknown')})"
                 for fact in user_profile.get("facts", [])
             )
+            if facts_text:
                 formatted_messages.append({"role": "system", "content": f"Knowledge about {user_name}:\n{facts_text}"})
 
         relevant_summaries = self.select_relevant_summaries(mid_term_summaries, prompt)
         for summary in relevant_summaries:
-                    formatted_messages.append({
+            formatted_messages.append(
+                {
                     "role": "system",
-                        "content": f"[{summary['timestamp']}] Topics: {', '.join(summary['topics'])}\n{summary['summary']}"
+                    "content": (
-                    })
+                        f"[{summary.get('timestamp', 'Unknown')}] "
+                        f"Topics: {', '.join(summary.get('topics', []))}\n"
+                        f"{summary.get('summary', '')}"
+                    ),
+                }
+            )
 
-            formatted_messages += [{"role": "user", "content": f"{entry['user']}: {entry['content']}"} for entry in memory]
+        formatted_messages += [
+            {"role": "user", "content": f"{entry.get('user', 'Unknown')}: {entry.get('content', '')}"}
+            for entry in memory
+        ]
         formatted_messages.append({"role": "user", "content": f"{user_name}: {prompt}"})
 
-
-            ##################################################
-            #                                                #
-            ## Generate AI Response, put into response_text ##
-            #                                                #
-            ##################################################
-
         response_text = await self.generate_response(api_key, formatted_messages)
 
-            ##################################################
-            #                                                #
-            ##################################################
-
-            # ✅ Store Memory
         memory.append({"user": user_name, "content": prompt})
         memory.append({"user": "Reginald", "content": response_text})
 
         if len(memory) > self.short_term_memory_limit:
-                summary = await self.summarize_memory(message, memory[:int(self.short_term_memory_limit * self.summary_retention_ratio)])
+            summary_batch_size = int(self.short_term_memory_limit * self.summary_retention_ratio)
-                mid_memory.setdefault(channel_id, []).append({
+            summary = await self.summarize_memory(message, memory[:summary_batch_size])
+
+            mid_term_summaries.append(
+                {
                     "timestamp": datetime.datetime.now().strftime("%Y-%m-%d %H:%M"),
                     "topics": self.extract_topics_from_summary(summary),
-                    "summary": summary
+                    "summary": summary,
-                })
+                }
-                if len(mid_memory[channel_id]) > self.summary_retention_limit:
+            )
-                    mid_memory[channel_id].pop(0)
-                memory = memory[-(self.short_term_memory_limit - int(self.short_term_memory_limit * self.summary_retention_ratio)):]
 
+            retained_count = max(1, self.short_term_memory_limit - summary_batch_size)
+            memory = memory[-retained_count:]
+
+        async with self.config.guild(guild).short_term_memory() as short_memory, self.config.guild(
+            guild
+        ).mid_term_memory() as mid_memory:
             short_memory[channel_id] = memory
+            mid_memory[channel_id] = mid_term_summaries[-self.summary_retention_limit :]
 
         await self.send_split_message(message.channel, response_text)
 
-
     def should_reginald_interject(self, message_content: str) -> bool:
-        """Determines if Reginald should respond to a message based on keywords."""
+        direct_invocation = {"reginald,"}
-        direct_invocation = {
-        "reginald,"
-    }
         message_lower = message_content.lower()
-    
         return any(message_lower.startswith(invocation) for invocation in direct_invocation)
 
-    @debug
+    async def _execute_tool_call(self, tool_call) -> str:
-    async def generate_response(self, api_key, messages):
+        func_name = tool_call.function.name
-        model = await self.config.openai_model()
+        target_function = CALLABLE_FUNCTIONS.get(func_name)
+
+        if target_function is None:
+            return json.dumps({"error": f"Unknown tool requested: {func_name}"})
+
         try:
-            client = openai.AsyncClient(api_key=api_key)
+            func_args = json.loads(tool_call.function.arguments or "{}")
+        except json.JSONDecodeError as error:
+            return json.dumps({"error": f"Invalid arguments for {func_name}: {error}"})
+
+        try:
+            result = await asyncio.to_thread(target_function, **func_args)
+        except Exception as error:
+            return json.dumps({"error": f"Tool {func_name} failed: {error}"})
+
+        if isinstance(result, str):
+            return result
+
+        return json.dumps(result, default=str)
+
+    @debug
+    async def generate_response(self, api_key: str, messages: list[dict]) -> str:
+        model = await self.config.openai_model() or DEFAULT_MODEL
+        try:
+            client = openai.AsyncOpenAI(api_key=api_key)
             completion_args = {
-                'model': model,
+                "model": model,
-                'messages': messages,
+                "messages": messages,
-                'max_tokens': 4096,
+                # `max_completion_tokens` is the recommended limit field for modern/reasoning models.
-                'temperature': 0.7,
+                "max_completion_tokens": DEFAULT_MAX_COMPLETION_TOKENS,
-                'presence_penalty': 0.5,
+                "temperature": DEFAULT_TEMPERATURE,
-                'frequency_penalty': 0.5,
+                "tools": TOOLS,
-                'tools': TOOLS,
+                "tool_choice": "auto",
-                'tool_choice': 'auto',
             }
             response = await client.chat.completions.create(**completion_args)
-            # Checking for function calls
+
-            tool_calls = response.choices[0].message.tool_calls
+            assistant_message = response.choices[0].message
-            # Appending response with tool calls
+            tool_calls = assistant_message.tool_calls or []
-            messages.append({
+
-                'role': 'assistant',
+            messages.append(
-                'content': response.choices[0].message.content,
+                {
-                'tool_calls': tool_calls
+                    "role": "assistant",
-            })
+                    "content": assistant_message.content or "",
+                    "tool_calls": tool_calls,
+                }
+            )
+
             if tool_calls:
-                for i_call in tool_calls:
+                for tool_call in tool_calls:
-                    # Calling for necessary functions
+                    tool_result = await self._execute_tool_call(tool_call)
-                    func_name = i_call.function.name
+                    messages.append(
-                    func_args = json.loads(i_call.function.arguments)
+                        {
-                    tool_call_id = i_call.id
+                            "role": "tool",
-                    # Getting function result and putting it into messages
+                            "content": tool_result,
-                    func_result = CALLABLE_FUNCTIONS[func_name](**func_args)
+                            "tool_call_id": tool_call.id,
-                    messages.append({
+                        }
-                        'role': 'tool',
+                    )
-                        'content': func_result,
-                        'tool_call_id': tool_call_id,
-                    })
 
                 completion_args["messages"] = messages
-                # Second completion required if functions has been called to interpret the result into user-friendly
-                # chat message.
                 response = await client.chat.completions.create(**completion_args)
 
             if response.choices and response.choices[0].message and response.choices[0].message.content:
@@ -239,17 +262,17 @@ class ReginaldCog(PermissionsMixin, BlacklistMixin, MemoryMixin, commands.Cog):
                     response_text = response_text[len("Reginald:") :].strip()
             else:
                 print("DEBUG: OpenAI response was empty or malformed:", response)
-                response_text = "⚠️ No response received from AI."
+                response_text = "No response received from AI."
 
             return response_text
 
-        except OpenAIError as e:
+        except OpenAIError as error:
-            error_message = f"OpenAI Error: {e}"
+            error_message = f"OpenAI Error: {error}"
             reginald_responses = [
                 f"Regrettably, I must inform you that I have encountered a bureaucratic obstruction:\n\n{error_message}",
                 f"It would seem that a most unfortunate technical hiccup has befallen my faculties:\n\n{error_message}",
                 f"Ah, it appears I have received an urgent memorandum stating:\n\n{error_message}",
-                f"I regret to inform you that my usual eloquence is presently obstructed by an unforeseen complication:\n\n{error_message}"
+                f"I regret to inform you that my usual eloquence is presently obstructed by an unforeseen complication:\n\n{error_message}",
             ]
             return random.choice(reginald_responses)
 
@@ -257,98 +280,76 @@ class ReginaldCog(PermissionsMixin, BlacklistMixin, MemoryMixin, commands.Cog):
     @commands.has_permissions(manage_guild=True)
     @commands.command(help="Set the OpenAI API key")
     async def setreginaldcogapi(self, ctx, api_key):
-        """Allows an admin to set the OpenAI API key for Reginald."""
         await self.config.guild(ctx.guild).openai_api_key.set(api_key)
         await ctx.send("OpenAI API key set successfully.")
 
-    @commands.command(name="reginald_set_listening_channel", help="Set the channel where Reginald listens for messages.")
+    @commands.command(
+        name="reginald_set_listening_channel",
+        help="Set the channel where Reginald listens for messages.",
+    )
     @commands.has_permissions(administrator=True)
     async def set_listening_channel(self, ctx, channel: discord.TextChannel):
-        """Sets the channel where Reginald will listen for passive responses."""
-        
         if not channel:
-            await ctx.send("❌ Invalid channel. Please mention a valid text channel.")
+            await ctx.send("Invalid channel. Please mention a valid text channel.")
             return
 
         await self.config.guild(ctx.guild).listening_channel.set(channel.id)
-        await ctx.send(f"✅ Reginald will now listen only in {channel.mention}.")
+        await ctx.send(f"Reginald will now listen only in {channel.mention}.")
 
-    @commands.command(name="reginald_get_listening_channel", help="Check which channel Reginald is currently listening in.")
+    @commands.command(
+        name="reginald_get_listening_channel",
+        help="Check which channel Reginald is currently listening in.",
+    )
     @commands.has_permissions(administrator=True)
     async def get_listening_channel(self, ctx):
-        """Displays the current listening channel."""
         channel_id = await self.config.guild(ctx.guild).listening_channel()
 
         if channel_id:
             channel = ctx.guild.get_channel(channel_id)
-            if channel:  # ✅ Prevents crash if channel was deleted
+            if channel:
-                await ctx.send(f"📢 Reginald is currently listening in {channel.mention}.")
+                await ctx.send(f"Reginald is currently listening in {channel.mention}.")
             else:
-                await ctx.send("⚠️ The saved listening channel no longer exists. Please set a new one.")
+                await ctx.send("The saved listening channel no longer exists. Please set a new one.")
         else:
-            await ctx.send("❌ No listening channel has been set.")
+            await ctx.send("No listening channel has been set.")
-
 
     async def send_long_message(self, ctx, message, prefix: str = ""):
-        """Splits and sends a long message to avoid Discord's 2000-character limit."""
+        chunk_size = 1900
-        chunk_size = 1900  # Leave some space for formatting
         if prefix:
-            prefix_length = len(prefix)
+            chunk_size -= len(prefix)
-            chunk_size -= prefix_length
 
         for i in range(0, len(message), chunk_size):
             chunk = message[i : i + chunk_size]
             await ctx.send(f"{prefix}{chunk}")
 
     async def send_split_message(self, ctx, content: str, prefix: str = ""):
-        """
+        chunk_size = 1900
-        Sends a long message to Discord while ensuring it does not exceed the 2000-character limit.
+        split_message = self.split_message(content, chunk_size, prefix)
-        This function prevents awkward mid-word or unnecessary extra message breaks.
-        """
-        CHUNK_SIZE = 1900  # Keep buffer for formatting/safety
-
-        split_message = self.split_message(content, CHUNK_SIZE, prefix)
         for chunk in split_message:
             await ctx.send(f"{prefix}{chunk}")
 
-    def split_message(
+    def split_message(self, message: str, chunk_size: int, prefix: str = "") -> list[str]:
-            self,
-            message: str,
-            chunk_size: int,
-            prefix: str = ""
-    ) -> list[str]:
-        """Results in a list of message chunks, use *for* loop to send."""
         chunk_size -= len(prefix)
         split_result = []
 
         if 0 < len(message) <= chunk_size:
-            # If the message is short enough, add it directly
             split_result.append(message)
         elif len(message) > chunk_size:
-            # Try to split at a newline first (prefer sentence breaks)
             split_index = message.rfind("\n", 0, chunk_size)
 
-            # If no newline, split at the end of sentence (avoid sentence breaks)
             if split_index == -1:
                 split_index = message.rfind(". ", 0, chunk_size)
 
-            # If no newline, split at the last word (avoid word-breaking)
             if split_index == -1:
                 split_index = message.rfind(" ", 0, chunk_size)
 
-            # If still no break point found, force chunk size limit
             if split_index == -1:
                 split_index = chunk_size
 
             message_split_part = message[:split_index].strip()
             message_remained_part = message[split_index:].strip()
-            # Put the split part in the begining of the result list
+
             split_result.append(message_split_part)
-            # And go for a recursive adventure with the remained message part
             split_result += self.split_message(message=message_remained_part, chunk_size=chunk_size)
 
         return split_result
-
-    async def setup(bot):
-        """✅ Correct async cog setup for Redbot"""
-        await bot.add_cog(ReginaldCog(bot))

reginaldCog/weather.py

@@ -1,10 +1,11 @@
 from datetime import datetime, timezone
 from os import environ
-import requests
 import json
 
-#WEATHER_API_KEY = environ.get('WEATHER_API_KEY')
+import requests
-URL = 'http://api.weatherapi.com/v1'
+
+URL = "https://api.weatherapi.com/v1"
+REQUEST_TIMEOUT_SECONDS = 10
 
 
 def time_now() -> str:
@@ -16,10 +17,14 @@ def get_current_weather(location: str) -> str:
     return json.dumps(weather.realtime())
 
 
-def get_weather_forecast(location: str, days: int = None) -> str:
+def get_weather_forecast(location: str, days: int = 0) -> str:
-    days += 1
+    if days is None:
+        days = 0
+
+    days = int(days) + 1
     days = max(1, days)
     days = min(14, days)
+
     weather = Weather(location=location)
     return json.dumps(weather.forecast(days=days))
 
@@ -27,7 +32,7 @@ def get_weather_forecast(location: str, days: int = None) -> str:
 class Weather:
     def __init__(self, location: str):
         self.__location = location
-        self.api_key = environ.get('WEATHER_API_KEY')
+        self.api_key = environ.get("WEATHER_API_KEY")
 
     @property
     def location(self) -> str:
@@ -35,28 +40,48 @@ class Weather:
 
     @staticmethod
     def make_request(method: str, params: dict) -> dict:
-        response = requests.get(url=f'{URL}{method}', params=params)
+        try:
-        return response.json()
+            response = requests.get(
+                url=f"{URL}{method}",
+                params=params,
+                timeout=REQUEST_TIMEOUT_SECONDS,
+            )
+            response.raise_for_status()
+            payload = response.json()
+        except requests.RequestException as error:
+            return {"error": f"Weather API request failed: {error}"}
+        except ValueError as error:
+            return {"error": f"Weather API returned invalid JSON: {error}"}
+
+        if isinstance(payload, dict) and "error" in payload:
+            api_error = payload["error"]
+            if isinstance(api_error, dict):
+                message = api_error.get("message", "Unknown weather API error")
+            else:
+                message = str(api_error)
+            return {"error": message}
+
+        return payload
 
     def realtime(self):
-        method = '/current.json'
+        method = "/current.json"
         params = {
-            'key': self.api_key,
+            "key": self.api_key,
-            'q': self.location,
+            "q": self.location,
         }
         return self.make_request(method=method, params=params)
 
     def forecast(self, days: int = 14):
-        method = '/forecast.json'
+        method = "/forecast.json"
         params = {
-            'key': self.api_key,
+            "key": self.api_key,
-            'q': self.location,
+            "q": self.location,
-            'days': days,
+            "days": days,
         }
         return self.make_request(method=method, params=params)
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
-    test_weather = Weather('Aqtobe')
+    test_weather = Weather("Aqtobe")
     result = json.dumps(test_weather.forecast(days=13), indent=2)
     print(result)